Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add bold realignment notebook (ISMRM'25 Experiment 2) #256

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Nov 6, 2024

No description provided.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (2ac0106) to head (fef5823).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          19       19           
  Lines         942      942           
  Branches      119      119           
=======================================
  Hits          624      624           
  Misses        274      274           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta
Copy link
Collaborator

jhlegarreta commented Nov 9, 2024

A few comments:

  • skimage and nipreps should be added to pyproject.toml.
  • Do you think that the plots could be transferred immediately or be useful for nireports? If yes, we could transfer them now; if they are useful but not yet ready, we could open an issue there and link to this PR.
  • We need to add the necessary code to retrieve the data and the scripts to preprocess them if applicable (in general for all notebooks; x-ref PR ENH: Add an additional environment to tox to run notebooks #257).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants