Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated command line arguments #1898

Closed
oesteban opened this issue Dec 3, 2019 · 2 comments · Fixed by #1909
Closed

Remove deprecated command line arguments #1898

oesteban opened this issue Dec 3, 2019 · 2 comments · Fixed by #1909
Assignees
Labels
effort: low Estimated low effort task impact: high Estimated high impact task
Milestone

Comments

@oesteban
Copy link
Member

oesteban commented Dec 3, 2019

We've been keeping some deprecated command-line arguments for some time - it is now the moment to drop them. These are:

  • --ignore-aroma-denoising-errors
  • --debug
  • --output-space
  • --template
  • --template-resampling-grid
  • --no-freesurfer
  • --output-grid-reference (this is only present on the wrapper).
@oesteban oesteban added impact: high Estimated high impact task effort: low Estimated low effort task labels Dec 3, 2019
@oesteban oesteban added this to the 1.6.0 milestone Dec 3, 2019
@mgxd
Copy link
Collaborator

mgxd commented Dec 10, 2019

Looking into this now - one question: is the docker wrapper meant to provide a very high level fmriprep call, while the fmriprep callable allows more fine-grain control? Or have we just not been synchronizing the two?

@effigies
Copy link
Member

The Docker wrapper is meant to turn something that looks like an fMRIPrep invocation into a docker command. Any option that's valid in fMRIPrep should be valid in fMRIPrep docker. But it passes most things through, uninspected, only parsing options that will require it to mount a volume or some other manipulation of Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Estimated low effort task impact: high Estimated high impact task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants