-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax for --output-spaces
- specify (non)standard spaces
#1604
Comments
Related: #1647 |
Let's say I want to have my EPI data in the T1w space, with 1mm isotropic voxel size. Is there currently a way to do this? I tried the following and it produced 1mm-resolution data in the MNI152NLin2009cAsym space, but the T1w space output used the voxel sizes from the EPI/BOLD data, as usual. (It produced the outputs I described but subsequently crashed because I used 'fs6' instead of 'fsaverage')
|
Hi @hhoke, this is a great question. At this point you can't do that. What kind of language would you suggest for the |
That's a shame! It's something we need for our lab's pipeline. What's your timeline for adding this feature? Is it a matter of tacking something on to existing abstractions or will it require serious reworking?
|
--output-spaces
- specify (non)standard spaces
@hhoke The I think it would be interesting to have more strict rules, with a wider portfolio of behaviors for this command-line argument. @effigies was not in favor of creating a whole new language for this, but I'm afraid we will need to. I think one should be able to do the following:
where we have one output in standardized space, one subject space, and two scanner spaces. Resolutions work as follow:
Then, users would be able to concatenate an arbitrary number of
Regarding the allowed space identifiers, they could take:
I'm just thinking out loud. Opinions to move forward? |
After reading through this once or twice, the general idea seems understandable to me. Two aspects are a little unclear:
|
Thanks for the super-timely feedback!
I think the ordering of the cohort selector does not impede a univocal interpretation. But, in relation to #1817, one might want to normalize to two cohorts and have varying sets of outputs:
Would produce
Then it will generate the How does this idea sound? And, is there something I'm not seeing about the ordering of the
Totally. We are working quite a bit on the documentation of TemplateFlow, which will help to describe this, and some updates on fMRIPrep's documentation will be necessary linking to TemplateFlow's.
This is a good point too. By the looks of this bids-standard/bids-specification#301 it seems that the resolution value will not be an index anymore - meaning, TemplateFlow will need to be updated. |
This sounds great, and is very clear! The place I saw the other order of
This might lead people to think that you have to first specify Re: TemplateFlow, I had seen that PR and the discussion of how |
Comes from https://github.com/poldracklab/fmriprep/pull/1596/files#r280788899
With the implementation of the
--output-spaces
command line argument, we opened the door to better specify how the user wants their output data in terms of spaces and gridding.After discussion on #1588, an interface was defined to standard target templates. This issue will focus on specifying the keywords and associated semantics for non-standard spaces.
Currently, fMRIPrep only supports
T1w
space, which has been given an aliasanat
. This means that using--output-spaces anat
(or--output-spaces T1w
), will lead to generating BOLD runs aligned with the anatomical reference created by fMRIPrep. By default, these runs are resampled in their native resolution (i.e., not in the anatomical's resolution).Here and in #1376, @a3sha2 proposed generating BOLD series in their native space. That would be a new keyword we would need to define (and so on, so forth).
Some ideas I'm currently entertaining is to have
run
,func
and(bold/sb)ref
as potential options for such native space. I would shy away fromnative
as we are also using it as a modifier and one could see--output-spaces MNI152Lin:native native
which seems weird.Pinging @satra, @edickie for a BIDS perspective.
The text was updated successfully, but these errors were encountered: