ENH: Revision of spaces module for consistency

[oesteban]

No description provided.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     ENH: Revision of spaces module for consistency

     enh: add helper function from fmriprep's PR

     Apply suggestions from code review

     enh: address review comments

     misc: add comment with link to code review conversation [skip ci]

     enh: allow checkpointing only if spaces are given at instantiation

Powered by Pull Assistant. Last update d36fb2c ... 3dfce2a. Read the comment docs.

[pep8speaks]

Hello @oesteban, Thank you for updating!

• In the file niworkflows/utils/spaces.py:

Line 553:17: W503 line break before binary operator
Line 554:17: W503 line break before binary operator
Line 578:13: W503 line break before binary operator
Line 579:13: W503 line break before binary operator
Line 589:13: W503 line break before binary operator
Line 590:13: W503 line break before binary operator

To test for issues locally, pip install flake8 and then run flake8 niworkflows.

Comment last updated at 2020-02-06 00:18:55 UTC

[codecov]

Codecov Report

Merging #457 into master will decrease coverage by 4.6%.
The diff coverage is 84.31%.

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   61.13%   56.52%   -4.61%     
==========================================
  Files          61       43      -18     
  Lines        6119     5054    -1065     
  Branches      711      717       +6     
==========================================
- Hits         3741     2857     -884     
+ Misses       2335     2064     -271     
- Partials       43      133      +90

Flag	Coverage Δ
#masks	?
#reportlettests	?
#unittests	?

Impacted Files	Coverage Δ
niworkflows/utils/spaces.py	88.48% <84.31%> (-6.46%)	⬇️
niworkflows/func/util.py	28% <0%> (-52%)	⬇️
niworkflows/interfaces/fixes.py	41.17% <0%> (-45.1%)	⬇️
niworkflows/interfaces/ants.py	57.81% <0%> (-16.15%)	⬇️
niworkflows/engine/workflows.py	26.31% <0%> (-15.79%)	⬇️
niworkflows/interfaces/bids.py	80.15% <0%> (-15.48%)	⬇️
niworkflows/interfaces/utility.py	75.47% <0%> (-13.21%)	⬇️
niworkflows/utils/bids.py	76.4% <0%> (-12.35%)	⬇️
niworkflows/interfaces/itk.py	28.39% <0%> (-10.5%)	⬇️
niworkflows/interfaces/registration.py	51.72% <0%> (-10.35%)	⬇️
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec7d3a...3dfce2a. Read the comment docs.