-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Write outputs in native-BOLD space #1646
Conversation
This PR enables writing data resampled after STC-HMC-SDC in their original BOLD grid. Closes nipreps#1376.
This is ready for review if you have the time @effigies . |
@@ -84,7 +84,11 @@ that do not generate *standardized* coordinate spaces: | |||
including the ``fsnative`` space will instruct fMRIPrep to sample the | |||
original BOLD data onto FreeSurfer's reconstructed surfaces for this | |||
individual. | |||
* **Additional nonstandard spaces** which are being discussed | |||
* ``func``, ``bold``, ``run``, ``boldref`` or ``sbref`` can be used to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these are all equivalent? My inclination would be to use boldref
, because there is a file with that suffix, and if people can get what that means, they'll understand this use. None of the others are as clear, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point all of them are equivalent. Once we make the corresponding decisions in the context of #1604, then we can refine the list.
That said, i) I agree with your inclination; and ii) when you have time -and probably this can wait until after OHBM-, let's dive into a concrete definition of nonstandard spaces and keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to check they're compressed?
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
The space-T1w datasinks have the same problem, would you change that within this PR? |
Yeah, I think so. I thought I did go through and add it to all of the NIfTI outputs recently, but that was maybe sMRIPrep. |
This PR enables writing data resampled after STC-HMC-SDC in their
original BOLD grid.
Closes #1376.