-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resample to T1w or use q/s-form for space-T1w
BOLD outputs?
#1647
Comments
@oesteban - just to clarify, you mean keep the moving image in its original resolution? |
Essentially yes (provided that by moving image you mean the BOLD run). Since the co-registration to the T1w is affine, the proposal would be to compose the appropriate affines (headers and registration) and rewrite the s/q-form matrix of A question would be whether we want to limit the t1-bold coregistration to only 6 parameters, so that we can keep setting both q and s forms to the same affine. |
@oesteban - bbregister allows 9 and 12 dof registration. as long as you don't enable that, you should be ok with restricting to 6. |
Yep. Alternatively, we could restrict to 6 only when susceptibility distortion was not corrected for (although I'm of the opinion that only 6 parameters should be allowed). |
I don't think we have to add a new keywords to
How about we do the header update if Also, I think 9-dof could be done if you're willing to update the voxel sizes in the header, but that might not be accepted practice... |
Sorry, I probably mixed up conversations. Problem 1 is whether we should/want to add the possibility of avoiding resampling of
Problem 2 would go beyond the scope of how outputs should be written. In this case the question would be whether we want to allow >6-dof for T1w-to-BOLD registration. I'm inclined to think that it should be 6-dof only (regardless what we decide in terms of resampling/xforms). |
My question was whether there's any good reason to keep around the resampling behavior for 6-dof, thus necessitating another This is somewhat frustrating, as I'd rather our CLI not turn into antsRegistration and become its own programming language. |
I failed to describe this as the background for Problem 1 this clear, thanks.
Totally :D |
@oesteban i think this can be closed after nipreps/smriprep#219? |
Nope, this is a different suggestion. The idea here is whether conversions should be resampled or use the s/q-form instead. It is related, but not exactly the same. |
After working on #1646 and consideration of #1376 (comment) I wanted to open the question whether the
space-T1w
images should be resampled into T1w space (as they are currently generated) or maybe we should just update the s/q-form headers to let the user do the resampling when needed.Maybe adding a modifier to the
--output-spaces
keyword would be appropriate. No modifier means resampling (current behavior), but--output-spaces T1w:xform
would enable this other option.WDYT @jooh, @effigies?
The text was updated successfully, but these errors were encountered: