Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pandas Index.ravel() #2904

Closed
effigies opened this issue Dec 6, 2022 · 0 comments · Fixed by #2937
Closed

Remove Pandas Index.ravel() #2904

effigies opened this issue Dec 6, 2022 · 0 comments · Fixed by #2937
Labels
maintenance
Milestone
23.0.0

Comments

@effigies
Copy link
Member

effigies commented Dec 6, 2022 

/opt/conda/lib/python3.9/site-packages/fmriprep/interfaces/confounds.py:558: FutureWarning: Index.ravel returning ndarray is deprecated; in a future version this will return a view on self.
  colnames = data.columns.ravel().tolist()
@effigies effigies moved this to Todo in Development Dec 6, 2022
@effigies effigies added this to the 23.0.0 milestone Dec 14, 2022
@effigies effigies mentioned this issue Jan 17, 2023
Merged
@effigies effigies moved this from Todo to In Progress in Development Jan 17, 2023
effigies added a commit that referenced this issue Jan 23, 2023
@effigies
RF: Use DataFrame.rename instead of ad hoc process (#2937)
5f42f5e 
## Changes proposed in this pull request

We had a use of deprecated `Index.ravel()` functionality. It turns out
this was to do the same thing as `DataFrame.rename(columns=mapper)`, so
I just replaced that.

Closes #2904.
@github-project-automation github-project-automation bot moved this from In Progress to Done (To be released) in Development Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
Development
Status: Done (To be released)
Milestone
23.0.0
Development

Successfully merging a pull request may close this issue.

RF: Use DataFrame.rename instead of ad hoc process effigies/fmriprep
1 participant
@effigies