Issues with reports after migrating to NiReports

[oesteban]

What happened?

With #3177, we may have provoked:

• The methods boilerplate is missing within the artifacts of ds005, ds054, and ds210 on CircleCI. It is present in the "smriprep" artifact folder of ds054 and ds210 (which I assume is because smriprep is generating the report here).
• ds054's report with error is currently not showing any errors
• Perhaps this was intended, but the partial run of ds005 does not have fieldmaps, while the full run has them.

What command did you use?

n/a

What version of fMRIPrep are you running?

master

How are you running fMRIPrep?

Other

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

[mgxd]

re: the second item, Chris and I were discussing in #3210

[oesteban]

re: the second item, Chris and I were discussing in #3210

I think that is a different problem (which I agree we need to resolve). My second item here "complains" that there is actually no errors section in the report, even though it used to have that section.

I'll engage on the other issue for the --reports-only error reporting, but here we have a problem in that, regardless you run full or --reports-only, you don't see any errors in the report.

[oesteban]

After merging #3191, I think we are getting to a much better place. However, the new unit tests are failing (which is a good thing in the sense we are exercising the new code :)

On Circle's "test_pytest" build:

reports/tests/test_reports.py::test_ReportSeparation[001-session_list0-True-True-3-expected_files0] FAILED