-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TST] Refactoring CircleCI setup #1092
Conversation
Moves `--use-aroma` to ds054 with two ideas: * Shorten ds005 which was growing too large (CIFTI, partial exec, etc.) * Remove SyN from ds054 because it has fieldmaps, and make time for AROMA. Overall, this PR should shorten the runtime of tests. Also, figures/ folder has been pruned out of the outputs check (reports can be visualized and this check is a source of many errors). When finished, this should fix nipreps#1090.
Something weird is happening. Moving AROMA to ds054 now gives:
And the weird issue of work/ subfolders not being stored as artifacts is replicated. |
This looks reasonable, but I guess we'll see when tests finish. |
.circleci/config.yml
Outdated
@@ -575,9 +577,10 @@ jobs: | |||
- run: | |||
name: Clean-up work directory | |||
command: | | |||
sudo find /tmp/ds000210/work -not -name "*.svg" -not -name "*.html" -not -name "*.rst" \ | |||
sudo chown $(id -un):$(id -gn) -R /tmp/ds000210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this solves the mystery of the cropped work/ directories. However, now we get:
Uploading /tmp/ds000210/derivatives/fmriprep/sub-02/figures/sub-02_task-cuedSGT_run-01_echo-1_bold_flirt.svg: SKIPPED, file is empty
My impression is that FMRIPREP has started to write empty files at some point o_o
fmriprep/interfaces/bids.py
Outdated
self._results['compression'].append(_copy_any(fname, out_file)) | ||
|
||
if len(self._results['compression']) == 1: | ||
self._results['compression'] = self._results['compression'][0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is over here, now. So I'll just re-note that you can drop these two lines.
Moves `--use-aroma` to ds054 with two ideas: * Shorten ds005 which was growing too large (CIFTI, partial exec, etc.) * Remove SyN from ds054 because it has fieldmaps, and make time for AROMA. Overall, this PR should shorten the runtime of tests. Also, figures/ folder has been pruned out of the outputs check (reports can be visualized and this check is a source of many errors). Supersedes nipreps#1092 (close nipreps#1092)
Moves
--use-aroma
to ds054 with two ideas:Overall, this PR should shorten the runtime of tests.
Also, figures/ folder has been pruned out of the outputs check (reports can be visualized and this check is a source of many errors).
When finished, this should fix #1090.