Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add two missing references #1234

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Aug 3, 2018

Changes proposed in this pull request

Adds two missing references to the bibtex database

Documentation that should be reviewed

Pull-request guidelines:

  1. We invite you to list yourself as a fMRIPrep contributor, so if your name
    is not already mentioned, please modify the
    .zenodo.json
    file with your data right above Russ' entry. Example:

    {
       "name": "Contributor, New FMRIPrep",
       "affiliation": "Department of fMRI prep'ing, Open Science Made-Up University",
       "orcid": "<your id>"
    },
    {
       "name": "Poldrack, Russell A.",
       "affiliation": "Department of Psychology, Stanford University",
       "orcid": "0000-0001-6755-0259"
    },
    
  2. By submitting this request you acknowledge that your contributions are available under the BSD 3-Clause license.

  3. Use a descriptive prefix, between brackets for your PR: ENH (enhancement), FIX, TST, DOC, STY,
    REF (refactor), CI (continous integration), MAINT (maintenance). Example:

    [ENH] Support for SB-reference in multi-band datasets
    

    For works-in-progress, add the WIP tag in addition to the descriptive prefix.
    Pull-requests tagged with [WIP] will not merged in until the tag is removed.

  4. Your PR will be reviewed according to the following
    template.

  5. Documentation is a fundamental aspect to the glass-box philosophy that fMRIPrep abides by.
    Please understand that the fMRIPrep team may (are likely to) request you to improve the documentation
    provided with this PR, within the PR or in future PRs.

Please review and check the following:

  • I have read the guidelines for contributions.
  • I understand that my contributions will not be merged unless the work is
    finished (i.e. no [WIP] tag remains in the title of my PR) and tests pass.
  • The proposed code follows the
    coding style,
    to the extent I understood them (and I will address any comments raised by the PR's reviewers in this regard).
  • (Optional) I opt-out from being listed in the .zenodo.json file.

@oesteban oesteban merged commit 6997af1 into nipreps:master Aug 5, 2018
@oesteban oesteban deleted the docs/missing-references branch August 5, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant