Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCKER: Pin conda environment more strictly #2853

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

effigies
Copy link
Member

Discovered while fixing some bugs in the release. Might as well see if the LTS build is holding up.

@effigies
Copy link
Member Author

effigies commented Sep 15, 2022

@mgxd @oesteban @bpinsard It's becoming difficult to have a consistent Python environment. I'm doing a full pin based on the environment in the 20.2.6 container, minus the nipreps. We're going to need to figure out how to walk dependencies forward while verifying their behavior.

Curious if others have better ideas than an environment.yml.

@effigies effigies changed the title CI: Select only one run UUID, make sure directory exists DOCKER: Pin conda environment more strictly Sep 15, 2022
@effigies
Copy link
Member Author

Bump @oesteban @bpinsard for thoughts. (I see @mgxd gave this a 👍.)

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it's heading in a good direction. I guess updating dependencies will become a bit more involved. Let's see how it goes and write some update script if necessary down the line.

@effigies effigies self-assigned this Sep 27, 2022
@effigies effigies merged commit 38f9492 into nipreps:maint/20.2.x Sep 27, 2022
@effigies effigies deleted the ci/fix_checks branch September 27, 2022 15:53
@effigies effigies mentioned this pull request Sep 27, 2022
effigies added a commit that referenced this pull request Jun 12, 2023
23.1.0 (June 12, 2023)

New feature release in the 23.1.x series.

This release substantially reworks the resampling to fsLR grayordinate space,
better accounting for partial volumes and high variance voxels. If you are
resampling using ``--project-goodvoxels``, we strongly recommend upgrading.

Fieldmap handling is improved, with better preference given to single-band
references in both PEPolar and SyN-SDC schemes. Additionally, fMRIPrep will
no longer estimate fieldmaps that are not intended to be used to correct BOLD
series, reducing unneeded processing.

This release removes ICA-AROMA from the fMRIPrep workflow. To use ICA-AROMA,
set ``MNI152NLin6Asym:res-2`` as a target output space. MELODIC and ICA-AROMA
can be run on the resulting images in a separate pipeline. For further
information on the reasoning behind this change, see
`GitHub issue #2936 <https://github.com/nipreps/fmriprep/issues/2936>`__.

This release increments the versions of ANTs and FSL bundled in the Docker
image.

With thanks to Eilidh MacNicol, Basille Pinsard and Taylor Salo for contributions
in fMRIPrep and SDCflows.

* FIX: Raise RuntimeError at build if echos have mismatched shapes (#3028)
* FIX: Inconsistent fmapless estimation when ignoring fieldmaps (#2994)
* FIX: Dilate BOLD mask by 2 voxels to prevent over-aggressive masking degrading T2* map estimation (#2986)
* FIX: Estimate free memory with "available", not "free" (#2985)
* ENH: Add ``--me-t2s-fit-method`` parameter (#3030)
* ENH: Resample BOLD to fsLR directly, dropping fsaverage intermediate (#3011)
* ENH: Allow SBref+EPI PEPolar fieldmaps to correct BOLD series (#3008)
* ENH: Remove ICA-AROMA from workflow and docs (#2966)
* RF: Filter fieldmaps based on whether they will be used to correct a BOLD series (#3025)
* MNT: Update ANTs pin in Docker image (#3016)
* MNT: Update governance docs (#2992)
* MNT: Refactor Docker build process (#2982)
* MNT: Pin conda environment more strictly (#2853)
* MNT: Require niworkflows ~1.3.6 (#2740)
* CI: Use registry for layer caching (#3012)
* CI: Upgrade docker orb (#2865)
effigies added a commit that referenced this pull request Jul 18, 2024
20.2.8 (July 18, 2024)

Bug-fix release in the 20.2.x LTS series.

We anticipate this being the final release in the 20.2.x LTS series.

* FIX: Select volumetric dseg.tsv from recent TemplateFlow releases (#3257)
* FIX: LTS package build (#3328)
* DOC: Read html_baseurl from RTD environment, if available (#3324)
* DOCKER: Pin conda environment more strictly (#2853)
* MNT: Require niworkflows ~1.3.6 (#2740)
* CI: Upgrade docker orb (#2865)

This release includes a number of fixes that have accumulated in niworkflows,
including the following fixes that affect fMRIPrep:

* FIX: Remove unused ANTs parameter that was removed in 2.4.1 (nipreps/sdcflows#431)
* FIX: Limit 3dQwarp to maximum 4 CPUs for stability reasons (nipreps/sdcflows#128)
* MAINT: Make call to scipy.stats.mode compatible with scipy 1.11.0 (nipreps/sdcflows#371)
* FIX: TSV2JSON should convert empty TSV files to empty JSON files (nipreps/niworkflows#747)
* FIX: Use copy function that does not preserve mtime when creating fsaverage
  directories (nipreps/niworkflows#703)
* FIX: Set pixdim[4] to match RepetitionTime (nipreps/niworkflows#679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (To be released)
Development

Successfully merging this pull request may close these issues.

2 participants