Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply a couple refurb suggestions #3151

Merged
merged 1 commit into from
Nov 21, 2023
Merged

STY: Apply a couple refurb suggestions #3151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fmriprep/interfaces/workbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
_cmd = "wb_command -metric-resample"

def _format_arg(self, opt, spec, val):
if opt in ["current_area", "new_area"]:
if opt in ("current_area", "new_area"):

Check warning on line 282 in fmriprep/interfaces/workbench.py

View check run for this annotation

Codecov / codecov/patch

fmriprep/interfaces/workbench.py#L282 

Added line #L282 was not covered by tests
if not self.inputs.area_surfs and not self.inputs.area_metrics:
raise ValueError(
"{} was set but neither area_surfs or" " area_metrics were set".format(opt)
Expand Down
2 changes: 1 addition & 1 deletion fmriprep/workflows/bold/outputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def prepare_timing_parameters(metadata: dict):
slice_timing = timing_parameters.pop("SliceTiming", [])

run_stc = len(slice_timing) > 1 and 'slicetiming' not in config.workflow.ignore
timing_parameters["SliceTimingCorrected"] = bool(run_stc)
timing_parameters["SliceTimingCorrected"] = run_stc

if len(slice_timing) > 1:
st = sorted(slice_timing)
Expand Down