Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf: Reconstruct motion confounds from minimal derivatives #3424

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

effigies
Copy link
Member

After an exploration in nipreps/fmripost-aroma#94, we now know how to reconstruct the original motion parameters (to at least 0.001 mm/rad precision) from the ITK transforms we generate.

To ensure consistency between single-shot and fit+apply runs, I propose to use this function in place of the original outputs.

I will add a regression test before merging, to ensure we notice if a change in nitransforms breaks this calculation.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base (c3cbe55) to head (da5a025).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3424      +/-   ##
==========================================
+ Coverage   72.33%   72.70%   +0.37%     
==========================================
  Files          57       57              
  Lines        4269     4327      +58     
  Branches      545      546       +1     
==========================================
+ Hits         3088     3146      +58     
  Misses       1065     1065              
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the feat/derivative-motion-params branch 3 times, most recently from 444b277 to 8df7b1b Compare January 29, 2025 22:19
@effigies effigies force-pushed the feat/derivative-motion-params branch from 8df7b1b to b0f543f Compare January 30, 2025 14:28
@effigies
Copy link
Member Author

effigies commented Feb 7, 2025

Timeseries are being generated, the outputs are close to those from master, and tests confirm the validity of the changes.

@effigies effigies merged commit f53185e into nipreps:master Feb 7, 2025
21 checks passed
@effigies effigies deleted the feat/derivative-motion-params branch February 7, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant