-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Skip version cache on read-only filesystems #862
Conversation
Hello @effigies, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-12-16 19:03:33 UTC |
Travis failures are #863. Will not include fix in this PR. |
Looks like its running its own version of the webapi locally: Guess I'll rerun job with ssh and inspect nginx logs to see what I can see. |
Did we ever figure this out? |
edde69a
to
deb6e49
Compare
SSHing in, I see:
(Message repeats...) Did some digging, and came up with nipreps/mriqcwebapi#47. Testing that here. |
IQM issue. @oesteban if you could have a look? Or anybody else qualified to look through Circle? |
18b8b60
to
a72f03e
Compare
Could you rebase? |
Fixes #853. Following nipreps/fmriprep#1830.
a72f03e
to
2c60a44
Compare
Tests passing and I got an in-principle approval a while back, so I'll go ahead and merge. I would suggest a release soonish since a lot of these issues are long-standing, though we might also need to release mriqcwebapi. I don't know if there are deployment issues there? |
note to myself -- slated for 0.15.3 or 0.16 whatever comes first, right? ;) |
You bet, but maybe the webapi wants to give us a nice surprise. @rwblair may actually know better than myself |
0.15.3 is out already. I would suggest 0.16, just to mark that it took some work and upgraders may need to consider dependencies. |
https://github.com/poldracklab/mriqc/ says latest release 0.15.2 |
There's a tag that didn't get an official release page. If you click in the releases, you'll see it. |
Fixes #853.
Following nipreps/fmriprep#1830.