FIX: "Goodvoxels" projection #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug deep within nipype workflow connection / join expansions that either: - mistakenly uses node.name rather than node._hierarchy to fetch the relevant node or - reuses a previous JoinNode's `_next_slot_index` In either case, the end result is some funky indexed connection (in this case it was looking for the fields `bold_fsLRJ3` and `bold_fsLRJ4`. I spent some time in the rabbit hole and came out empty-handed, but the easiest solution seems to be just renaming them to something unique. Pain.
|
Merging this for dev testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates changes from nipreps/fmriprep#3011, taking some deviations to handle the case of MCRIBS surface processing.