Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sty: Address ruff complaints #64

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Jan 23, 2025

No description provided.

@jhlegarreta
Copy link
Contributor Author

Can be merged immediately. Making PR #28 more lightweight. I am working on cleaning a little bit some commits to make it easier to review.

@effigies
Copy link
Member

The removed import doesn't make sense without replacing the nb.load call.

@jhlegarreta jhlegarreta changed the title STYLE: Fix miscellaneous style issues sty: Address ruff complaints Jan 23, 2025
@jhlegarreta
Copy link
Contributor Author

The removed import doesn't make sense without replacing the nb.load call.

🦅 💯 removed in the corresponding commit in PR#28 Thanks.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (a8b4dd5) to head (66f5b63).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files          20       20           
  Lines         977      977           
  Branches      129      129           
=======================================
  Hits          659      659           
  Misses        265      265           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 75d26c6 into nipreps:main Jan 23, 2025
10 checks passed
@jhlegarreta jhlegarreta deleted the FixStyleIssues branch January 23, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants