-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add a shell data property to DWI
data class
#74
base: main
Are you sure you want to change the base?
Conversation
Opened as draft as I cannot debug this locally due to issue #73. Edit: There seems to be some data formatting to be done to compare the DWI data obtained to the expected data, but the approach seems to be working otherwise: Edit: managed to debug locally undoing the type hinting related stuff. Ready to be reviewed. |
a516c84
to
3b62135
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 68.78% 68.91% +0.12%
==========================================
Files 20 20
Lines 958 962 +4
Branches 121 121
==========================================
+ Hits 659 663 +4
Misses 254 254
Partials 45 45 ☔ View full report in Codecov by Sentry. |
eca3f42
to
7b7eb25
Compare
Maybe it is worthwhile thinking about the interplay between this feature and the b-value iterators, and how the whole thing fits into the estimators' pipelining philosophy. |
2bbb863
to
5cd14cd
Compare
40e6519
to
20243e1
Compare
Add a shell data property to `DWI` data class that returns a list of pairs consisting of the estimated b-value and the associated DWI data. Co-authored-by: Oscar Esteban <code@oscaresteban.es>
20243e1
to
ad46aa3
Compare
I agree. In our last iteration we made the iterators independent of the object, so now you could go shell by shell and run any available iterator (those without concept of b-value, evidently). |
dwi_h5 = load(datadir / "dwi.h5") | ||
num_bins = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the bvecs/bvals files we added for testing? They are within the repo (i.e., no need to pull extra data from GIN) and they provide several use-cases ideal for testing this.
Add a shell data property to
DWI
data class that returns a list of pairs consisting of the estimated b-value and the associated DWI data.Closes #66.