Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update main flowchart and make modality-agnostic #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Mar 19, 2025

nifreeze-flowchart

Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @oesteban 💯.

Some comments:

  • "Estimate of the misalignment (...)" : "Estimate misalignment (...)".
  • "Model" in "Drop-in Model" and "Mapping" in "Spatial Mapping" have their first letters capitalized: none of the rest of titles have them. I'd use lowercase for these as well.
  • The "modality-specific structure box" is unclear to me: the distinction between "Baseline artifact" and "Artifact estimate" is unclear: the name suggest they are an artifact, but the text is about transforms. Can this be clarified/put some other way?
  • The RR figure caption mentions a target but the picture contains no target text. It should be added so that it can be referred to by the caption.

@jhlegarreta
Copy link
Contributor

jhlegarreta commented Mar 23, 2025

@oesteban type-check and other errors are being addressed in PR #83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants