Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Display errors as summary/details elements #464

Merged
merged 3 commits into from
Feb 26, 2020
Merged

ENH: Display errors as summary/details elements #464

merged 3 commits into from
Feb 26, 2020

Conversation

effigies
Copy link
Member

@pull-assistant
Copy link

pull-assistant bot commented Feb 26, 2020 •
edited
Loading

Score: 0.69

Best reviewed: commit by commit

Optimal code review plan

     ENH: Display errors as summary/details elements

     ENH: Drop list styling for no errors

     TEST: Update expected HTML doc length

Powered by Pull Assistant. Last update 528e525 ... 3dc605b. Read the comment docs.

@effigies
Copy link
Member Author

This targets a 1.1.8 release to support an fMRIPrep 20.0.1 release.

@effigies effigies mentioned this pull request Feb 26, 2020
Closed
mgxd
mgxd approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

niworkflows/reports/report.tpl Outdated Show resolved Hide resolved
@mgxd mgxd added this to the 1.1.8 milestone Feb 26, 2020
@effigies
Copy link
Member Author

With error: https://12096-53175327-gh.circle-artifacts.com/0/tmp/ds054/derivatives/fmriprep/sub-100185.html#errors

Without error: https://12096-53175327-gh.circle-artifacts.com/0/tmp/ds054/derivatives/fmriprep/sub-100185_noerror.html#errors

@effigies effigies changed the base branch from master to maint/1.1.x February 26, 2020 17:58
@effigies effigies merged commit e921564 into nipreps:maint/1.1.x Feb 26, 2020
@effigies effigies deleted the enh/error_details branch February 26, 2020 19:10
effigies added a commit to nipreps/fmriprep that referenced this pull request Feb 27, 2020
@effigies
Merge tag '20.0.1'
6a64770 
20.0.1 (February 27, 2020)

Bug-fix release in 20.0.x series.

This release includes fixes for rare images with invalid qform matrices and some minor
improvements in report readability and inclusion of common templates in the Docker image.

  * FIX: Handle qforms with invalid quaternions (nipreps/niworkflows#466)
  * FIX: update niworkflows location (#2005)
  * ENH: Display errors as summary/details elements in reports (nipreps/niworkflows#464)
  * DOC: Add ``--fs-subjects-dir`` usage to slurm example (#2003)
  * CI: Test that Docker image can run a common set of output spaces without network access (#1997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgxd mgxd mgxd approved these changes

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@effigies @oesteban @mgxd