Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN: svgutils to previous versions #596

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Jan 6, 2021

See #595 for context

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (maint/1.3.x@fd0a5a5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             maint/1.3.x     #596   +/-   ##
==============================================
  Coverage               ?   46.94%           
==============================================
  Files                  ?       43           
  Lines                  ?     5287           
  Branches               ?      770           
==============================================
  Hits                   ?     2482           
  Misses                 ?     2721           
  Partials               ?       84           
Flag Coverage Δ
documentation 0.00% <0.00%> (?)
reportlettests 100.00% <0.00%> (?)
unittests 47.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0a5a5...d984f10. Read the comment docs.

@mgxd mgxd merged commit 4d9b741 into nipreps:maint/1.3.x Jan 7, 2021
@mgxd mgxd deleted the pin/svgutils branch January 7, 2021 14:01
@effigies
Copy link
Member

effigies commented Jan 7, 2021

In retrospect, maybe just pinning !=0.3.2 would be safer. An == is fragile for a dependency instead of a user facing app.

@mgxd
Copy link
Contributor Author

mgxd commented Jan 7, 2021

Yeah, definitely more room for error. Do you feel strongly about changing it, or shall we just wait for a new svgutils release?

@effigies
Copy link
Member

effigies commented Jan 7, 2021

I don't think it's urgent to change before they release, but I don't think we should release a library with an == dependency, so any niworkflows release process should include updating to !=0.3.2. (Since they're fixing now, I think we can safely ignore the possibility of a broken 0.3.3 or 0.4.0.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants