TEST: Fix plugin invocation, use an initializer that can be verified #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
==========================================
- Coverage 70.54% 70.52% -0.03%
==========================================
Files 87 87
Lines 8202 8203 +1
Branches 949 949
==========================================
- Hits 5786 5785 -1
- Misses 2409 2411 +2
Partials 7 7 ☔ View full report in Codecov by Sentry. |
mgxd
reviewed
Jul 18, 2024
Comment on lines
91
to
92
| _process_initializer=touch_file, | ||
| file_path=init_flag, |
Contributor
There was a problem hiding this comment.
niworkflows/niworkflows/engine/plugin.py
Lines 449 to 454 in 1dc0327
We should really document somewhere _process_initializer's expected signature - I got burned by this.
Member
Author
There was a problem hiding this comment.
Please see the latest changes.
effigies
force-pushed
the
fix/nipype-plugin
branch
from
b67226e to
a5e7c67
Compare
mgxd
added a commit
that referenced
this pull request
Jul 31, 2024
1.11.0 (July 31, 2024) New minor release to start the 1.11.x series. The major changes include: - a deprecation to T1w-only based template processing - addition of a new dependency ``acres`` for accessing package data However, this is still backwards compatible with the 1.10.x series. * MAINT: Depend on acres for data access * ENH: Add PrepareDerivative/SaveDerivative interfaces (#885) * ENH: Make template dimensions support T2w as well (#879) * ENH: Modify FSSource to output T2 (#868) * FIX: Set cal_max in the NIfTI header for visualization after ``IntensityClip`` (#878) * FIX: Remove accidental MRIQC dependency, allow app config to be passed to workflow plugin (#876) * TEST: Fix plugin invocation, use an initializer that can be verified (#880)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #876, which didn't actually test what we wanted it to. We were manually calling
print()inside the test and interpreting that as being run on process initialization. We need to pass the config toMultiProcPlugin(), notworkflow.run().capsysdoes not capture stdout from subprocesses, it seems, so instead I'm telling the subprocesses to touch a file that I choose.