-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(brain_extraction_wf): Pass inu_n4 to atropos_wf #929
base: maint/1.3.x
Are you sure you want to change the base?
Conversation
antsBrainExtraction.sh passes the original N4 corrected image to Atropos, where we have been running a masked N4 before Atropos. We have examples where this difference leads to failures that do not occur in the original ANTs workflow. Further, if we do run Atropos, then this result is discarded and N4 is run using a white-matter mask. This patch therefore simply passes the original N4 image to the Atropos workflow, but otherwise leaves the workflow unchanged.
@yohanchatelain I wonder if it would be possible for you to see if this change would have a significant impact on the metrics that you were calculating for the paper. You should be able to use the following Dockerfile: FROM nipreps/fmriprep:20.2.8
RUN pip install --no-cache-dir git+https://github.com/nipreps/niworkflows.git@refs/pull/929/head I believe it should be minimal, but if we could confirm/disconfirm that, it would help justify whether we can make a release in the LTS series or if I need to find some other way to make this patch available to users. |
Hi @effigies, |
Just to be clear, 20.2.8 was released last July, so this will be a patch on that. If you don't have stats for that, however, comparing to 20.2.7 would be fine. |
Ok I see, so we need to check this patch against the 20.2.8 release version. |
@yohanchatelain Just checking in. Do you have an estimate of how long it will take to analyze the changes? |
Hi @effigies, the longest subject takes approximately 5 days to run with fuzzy, so I should have the results next week. |
Awesome, thanks! |
@yohanchatelain Just checking in today since I'll be out tomorrow. |
antsBrainExtraction.sh passes the original N4 corrected image to Atropos, where we have been running a masked N4 before Atropos. We have examples where this difference leads to failures that do not occur in the original ANTs workflow. Further, if we do run Atropos, then this result is discarded and N4 is run using a white-matter mask.
This patch therefore simply passes the original N4 image to the Atropos workflow, but otherwise leaves the workflow unchanged.
Addresses #928. This targets the LTS branch
maint/1.3.x
. Will leave that issue open until this or another patch is merged intomaster
.