Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement B0FieldIdentifier in FieldmapEstimation object #125

Closed
oesteban opened this issue Nov 22, 2020 · 0 comments · Fixed by #130
Closed

Implement B0FieldIdentifier in FieldmapEstimation object #125

oesteban opened this issue Nov 22, 2020 · 0 comments · Fixed by #130
Labels
BIDS & Derivatives effort: medium Estimated medium effort task impact: high Estimated high impact task
Milestone
2.0.0

Comments

@oesteban
Copy link
Member

To facilitate the implementation of bids-standard/bids-specification#622 if that comes through, with the following:

  1. Extend FieldmapEstimation with an id property, and to keep a register of unique IDs (to ensure there're no duplicities).
  2. Read the id from the BIDS metadata. If the id is not present, generate one automatically and forward it to the derivatives.
  3. Make sure the id makes it to the subworkflow name to ensure correct Nipype performance and avoid collisions.
@oesteban oesteban mentioned this issue Nov 22, 2020
Merged
@oesteban oesteban added BIDS & Derivatives impact: high Estimated high impact task effort: medium Estimated medium effort task labels Nov 23, 2020
@oesteban oesteban added this to the 1.4.0 milestone Nov 26, 2020
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 26, 2020
@oesteban
ENH: Keep a registry of already-used identifiers (and auto-generate new)
cf7682c 
Resolves: nipreps#125.
@oesteban oesteban mentioned this issue Nov 26, 2020
Merged
@oesteban oesteban linked a pull request Nov 26, 2020 that will close this issue
ENH: Keep a registry of already-used identifiers (and auto-generate new) #130
Merged
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 26, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
bb4931c 
Resolves: nipreps#125.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 26, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
0b31473 
Resolves: nipreps#125.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 27, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
5fee784 
Resolves: nipreps#125.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 27, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
b5fdecd 
Resolves: nipreps#125.
oesteban added a commit that referenced this issue Nov 30, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
21e75d0 
Resolves: #125.
oesteban added a commit that referenced this issue Dec 1, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
d879808 
Resolves: #125.
oesteban added a commit that referenced this issue Dec 3, 2020
@oesteban
enh: keep a registry of already-used identifiers (and auto-generate new)
b9bc76a 
Resolves: #125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BIDS & Derivatives effort: medium Estimated medium effort task impact: high Estimated high impact task
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

ENH: Keep a registry of already-used identifiers (and auto-generate new) oesteban/sdcflows
1 participant
@oesteban