Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/finish Phasediff SDC regularization with B-Splines #14

Closed
1 task done
oesteban opened this issue May 28, 2019 · 2 comments · Fixed by #119
Closed
1 task done

Improve/finish Phasediff SDC regularization with B-Splines #14

oesteban opened this issue May 28, 2019 · 2 comments · Fixed by #119
Assignees
@oesteban
Labels
effort: high Estimated high effort task GRE - phase1&2 GRE - phasediff impact: high Estimated high impact task
Milestone
2.0.0

Comments

@oesteban
Copy link
Member

oesteban commented May 28, 2019 •
edited
Loading

  • Drop CPython module, use scipy.
@oesteban oesteban transferred this issue from nipreps/fmriprep Jul 9, 2019
@oesteban oesteban mentioned this issue Aug 7, 2019
Closed
@oesteban oesteban added this to the 1.1.0 milestone Nov 25, 2019
This was referenced Dec 2, 2019
Merged
Closed
@oesteban oesteban modified the milestones: 1.2.0, 1.3.0 Dec 18, 2019
@oesteban oesteban mentioned this issue Mar 31, 2020
Closed
@oesteban oesteban modified the milestones: 1.4.0, 1.3.0 Apr 15, 2020
@oesteban oesteban added effort: high Estimated high effort task impact: high Estimated high impact task labels Apr 15, 2020
@oesteban oesteban self-assigned this Apr 15, 2020
@oesteban
Copy link
Member Author

oesteban commented Apr 15, 2020 •
edited
Loading

Taking on this would end with a bunch of issues using legacy code (#33), and produce much better results (#23, #22, #71, #72). It could even be used with our current PEPOLAR implementation, which could use some regularization.

@oesteban oesteban modified the milestones: 1.4.0, 1.5.0 Jun 12, 2020
@oesteban oesteban mentioned this issue Nov 12, 2020
Merged
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 14, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
f11e35e 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 14, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
eed5db6 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 14, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
f1d4271 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
@oesteban oesteban mentioned this issue Nov 14, 2020
Merged
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 14, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
c363a9d 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 14, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
02a3b46 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 16, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
a50b2c3 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 16, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
3dd0aab 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
@oesteban oesteban modified the milestones: 1.5.0, 1.4.0 Nov 18, 2020
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 19, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
00405f8 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 22, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
8ad0e0e 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 22, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
b615e3e 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
oesteban added a commit to oesteban/sdcflows that referenced this issue Nov 25, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
7b2d602 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: nipreps#71, nipreps#22.
Resolves: nipreps#72.
Resolves: nipreps#14.
@oesteban
Copy link
Member Author

Implemented in #119.

oesteban added a commit that referenced this issue Nov 26, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
339cd5a 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: #71, #22.
Resolves: #72.
Resolves: #14.
oesteban added a commit that referenced this issue Nov 30, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
7d3f10d 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: #71, #22.
Resolves: #72.
Resolves: #14.
oesteban added a commit that referenced this issue Dec 1, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
88cceab 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: #71, #22.
Resolves: #72.
Resolves: #14.
oesteban added a commit that referenced this issue Dec 3, 2020
@oesteban
ENH: A 3D tensor B-Spline approximator and extrapolator
74496c5 
This PR finally adds an implementation for B-Spline smoothing and
extrapolation of fieldmaps.

References: #71, #22.
Resolves: #72.
Resolves: #14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oesteban oesteban

Labels
effort: high Estimated high effort task GRE - phase1&2 GRE - phasediff impact: high Estimated high impact task
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

ENH: A 3D tensor B-Spline approximator and extrapolator oesteban/sdcflows
1 participant
@oesteban