Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Ensure IntendedFor metadata is a subject-relative path #360

Merged
merged 2 commits into from
Jun 1, 2023
Merged

FIX: Ensure IntendedFor metadata is a subject-relative path #360

merged 2 commits into from
Jun 1, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Jun 1, 2023

@effigies effigies added this to the 2.5.0 milestone Jun 1, 2023
@effigies effigies requested review from mgxd and oesteban June 1, 2023 14:18
@effigies
Copy link
Member Author

effigies commented Jun 1, 2023

@mgxd @oesteban This is a high priority fix. I would like to release sdcflows today to get the ball rolling on an fMRIPrep release on Monday.

mgxd
mgxd approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix 👍

@effigies effigies merged commit 4aa93fc into nipreps:master Jun 1, 2023
@effigies effigies deleted the fix/synthetic_intendedfor branch June 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgxd mgxd mgxd approved these changes

@oesteban oesteban Awaiting requested review from oesteban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

TypeError: Object of type BIDSImageFile is not JSON serializable
2 participants
@effigies @mgxd