-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF/FIX: Prioritize sbref and shortest echo for SyN-SDC #364
Conversation
I should probably add similar tests for multiecho pepolar. Can do that in this or a separate PR. @mgxd Sorry to be bugging you, but I'd really like to get fMRIPrep out this week if I can, and this is a blocker. If you have time, I'd appreciate a speedy review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM- this functionality seems self-contained enough to potentially be a separate function
3ba7ceb
to
7f9b2ca
Compare
Not a massive refactor, but at least it encapsulated it. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean
This PR resolves the twin issues of either creating an estimator per echo or including all echos (with different contrast and dropout properties) in multi-echo SyN.
Because we want the shortest echo, the simplest way to do this was to sort all possible EPIs by suffix and echo time, to push the shortest echo sbref to the front of the line, or the shortest echo bold/dwi, failing that. We then set "IntendedFor" to the set of sbrefs/echos matching all other entities/path components. Keeping track of what files have been included in an "IntendedFor" avoids finding multiple estimators for a set.
New estimator results:
Closes #363.