-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong probseg fmriprep output from freesurfer pipeline #254
Comments
This issue is still present for version 20.2.2. It looks that something is not working properly in smriprep.workflows.anatomical, for the case with freesurfer: the part which is converting the .aseg file from freesurfer (which looks fine) to t1w_tpms is somehow doing something wrong. |
Here is another illustration. T1w image from 1 subject, preprocessed with FMRIPREP and normalized to MNI152NL2009cAsym. 2nd case: same input T1w image, but this time, the overlapping TPM of CSF was generated from the fmriprep stream with the flag I wish I could help but I don't really understand how this code works, especially the part converting freesurfer outputs to fmriprep derivatives: |
Yes, I think we can agree on these tissue probability maps being poor. I think the one issue is that I never bothered to find the right way to generate tissue probability maps (as in GM, WM and CSF) from FreeSurfer outputs. If someone more versed in FreeSurfer (@ahoopes?) could give me a hand, it would be very much appreciated. Right now we are just mapping labels from aseg to {WM, GM, CSF}. |
Okay, I'm assigning this to the upcoming new release, as new TPMs will drastically affect the results of aCompCor. |
There's no direct way to generate gm/wm/csf tissue probabilities in FS, but you could add the |
@ahoopes Can |
@mgxd @oesteban I have a pre-run FreeSurfer with v6.0.1 in
I re-ran with FreeSurfer 7.2.0:
The good news is that the resulting |
Is there a significant time difference vs running with a single thread? If not, adding 25 mins might be fine... |
Haven't tested the effect of threading. |
No significant increase (25m38s to 27m2s) in runtime going from 7 to 1 thread, and no change in output. So that's at least a reasonable first pass. Should still look into reusing if we can... |
Good point, may be the easiest solution for now.. |
The only reason is to minimize the use of commercially restricted FSL. But in the short term, it might actually be a decent solution. An alternative to post-processing these posteriors and avoiding FSL (while being an acceptable solution with |
Sounds good. Then, in order not to block a 21.0.0 release, we will revert to FAST for now. Let's make an issue to further explore FreeSurfer/ANTs replacements for 21.1. |
Just looked at the code a bit. It's kind of a hidden feature, so there's no much (or any) documentation. The |
Hi, I noticed that the output of the segmentation from the freesurfer pipeline vs the FLIRT pipeline produced different probseg files. Especially, the probseg files from Freesurfer pipeline stream are binarized and not looking nice at all.
probseg-GM produced through Freesurfer pipeline:
probseg-GM produced through FSL pipeline:
probseg-GM + WM with Freesurfer pipeline:
probseg-GM + WM with FSL pipeline:
probseg-WM with FS pipeline:
wm.mgz file in the freesurfer folder: it looks ok!
Has anybody also noticed this on its data?
What version of fMRIPrep are you using?
20.2.0
What kind of installation are you using? Containers (Singularity, Docker), or "bare-metal"?
Singularity
What is the exact command-line you used?
Have you checked that your inputs are BIDS valid?
Yes
Did fMRIPrep generate the visual report for this particular subject? If yes, could you share it?
Can you find some traces of the error reported in the visual report (at the bottom) or in crashfiles?
Are you reusing previously computed results (e.g., FreeSurfer, Anatomical derivatives, work directory of previous run)?
Yes Freesurfer results were re-used
fMRIPrep log
If you have access to the output logged by fMRIPrep, please make sure to attach it as a text file to this issue.
The text was updated successfully, but these errors were encountered: