Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Revert to FAST #263

Merged
merged 1 commit into from
Aug 31, 2021
Merged

FIX: Revert to FAST #263

merged 1 commit into from
Aug 31, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 30, 2021

Closes #254.

Open question: This changes the workflow graph, but only by changing the branch that is followed. Is this acceptable to put in 0.7.x for use in fMRIPrep 20.2.x (ref Versions Matrix)?

@effigies effigies force-pushed the fix/revert_to_fast branch 2 times, most recently from 651a31c to 5bfcaaa Compare August 30, 2021 19:05
@effigies effigies requested review from mgxd and oesteban and removed request for mgxd August 30, 2021 20:30
@effigies effigies force-pushed the fix/revert_to_fast branch from 5bfcaaa to 4e1ea40 Compare August 30, 2021 21:35
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get the CI changes in separately, but looks good.

Open question: This changes the workflow graph, but only by changing the branch that is followed. Is this acceptable to put in 0.7.x for use in fMRIPrep 20.2.x (ref Versions Matrix)?

I think we should allow it, since this change falls under the umbrella of a bug-fix (the FS derived TPMs do not look good).

@effigies effigies force-pushed the fix/revert_to_fast branch from 4e1ea40 to 2b9c491 Compare August 30, 2021 21:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #263 (2b9c491) into master (d160455) will decrease coverage by 3.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   68.64%   65.36%   -3.28%     
==========================================
  Files          16       16              
  Lines        1078     1077       -1     
  Branches      155      155              
==========================================
- Hits          740      704      -36     
- Misses        288      326      +38     
+ Partials       50       47       -3     
Flag Coverage Δ
ds005 59.05% <80.00%> (-2.64%) ⬇️
ds054 50.97% <80.00%> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smriprep/workflows/anatomical.py 53.59% <100.00%> (-15.24%) ⬇️
smriprep/interfaces/reports.py 77.21% <0.00%> (-15.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d160455...2b9c491. Read the comment docs.

@effigies effigies merged commit 4010675 into nipreps:master Aug 31, 2021
@effigies effigies deleted the fix/revert_to_fast branch August 31, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong probseg fmriprep output from freesurfer pipeline
3 participants