Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Improvements to the CircleCI workflow #162

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

oesteban
Copy link
Member

- Don't deploy to Pypi if ``build_docs`` fails (close nipreps#150)
- Do not cache reportlets folder (see nipreps#159 (comment))
@oesteban oesteban requested review from effigies and mgxd January 29, 2020 16:47
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #162 into master will decrease coverage by 50.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #162       +/-   ##
===========================================
- Coverage   77.64%   27.11%   -50.54%     
===========================================
  Files          15       15               
  Lines         841      841               
  Branches      104      104               
===========================================
- Hits          653      228      -425     
- Misses        145      603      +458     
+ Partials       43       10       -33
Flag Coverage Δ
#ds005 ?
#ds054 ?
Impacted Files Coverage Δ
smriprep/cli/run.py 2.65% <0%> (-71.69%) ⬇️
smriprep/workflows/norm.py 31.57% <0%> (-68.43%) ⬇️
smriprep/__main__.py 16.66% <0%> (-66.67%) ⬇️
smriprep/workflows/surfaces.py 14.44% <0%> (-64.45%) ⬇️
smriprep/workflows/outputs.py 13.59% <0%> (-57.29%) ⬇️
smriprep/workflows/base.py 30.9% <0%> (-54.55%) ⬇️
smriprep/workflows/anatomical.py 23.94% <0%> (-53.53%) ⬇️
smriprep/interfaces/freesurfer.py 19.69% <0%> (-40.91%) ⬇️
smriprep/interfaces/reports.py 57.33% <0%> (-24.01%) ⬇️
smriprep/utils/bids.py 56.66% <0%> (-6.67%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb708ac...943b8bb. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@mgxd mgxd merged commit 6a556bc into nipreps:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCI: Do not deploy to pypi if build_docs fails
4 participants