-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Adopt ruff for linting and formatting #397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 76.98% 76.85% -0.13%
==========================================
Files 28 28
Lines 2042 2044 +2
Branches 240 236 -4
==========================================
- Hits 1572 1571 -1
- Misses 438 442 +4
+ Partials 32 31 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
effigies
added a commit
to nipreps/fmriprep
that referenced
this pull request
Feb 5, 2024
Follow-up to nipreps/smriprep#397. This should replace #3185 and #3147. I would review this commit-by-commit, and skip c0f2183, which was a pretty safe run of `ruff format` and `ruff --fix`. It's dominated by quote changes, so I would ignore it. Everything else could stand a review.
effigies
added a commit
that referenced
this pull request
Mar 20, 2024
0.14.0 (March 11, 2024) New feature release in the 0.14.x series. This release restores correct handling of cohort identifiers in templates. A feature release is warranted due to changes in the workflow structure. * FIX: Fetch templates during workflow construction (#418) * FIX: Re-add cohort identifier to template name (#416) * FIX: Repair FreeSurfer Dependency in Dockerfile (tcsh) (#404) * FIX: Invert result of skull-strip check in auto mode (#402) * STY: Adopt ruff for linting and formatting (#397) * CHORE: Update ruff, ignore certain rules (#419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages:
--fix
flag that can take care of a lot of problems with no user effort.Disadvantages:
I've added
.git-blame-ignore-rev
to hide a lot of this.Closes #395.