Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Apply Repo-Review suggestions #422

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Mar 21, 2024

PP302: Sets a minimum pytest to at least 6
Must have a minversion=, and must be at least 6 (first version to support pyproject.toml configuration).

PP304: Sets the log level in pytest
log_cli_level should be set. This will allow logs to be displayed on failures.

PP305: Specifies xfail_strict
xfail_strict should be set. You can manually specify if a check should be strict when setting each xfail.

PP306: Specifies strict config
--strict-config should be in addopts = [...]. This forces an error if a config setting is misspelled.

PP307: Specifies strict markers
--strict-markers should be in addopts = [...]. This forces all markers to be specified in config, avoiding misspellings.

PP308: Specifies useful pytest summary
An explicit summary flag like -ra should be in addopts = [...] (print summary of all fails/errors).

RF201: Avoid using deprecated config settings
extend-ignore deprecated, use ignore instead (identical)
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.99%. Comparing base (37165a4) to head (440579b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   62.99%   62.99%           
=======================================
  Files          24       24           
  Lines        1927     1927           
  Branches      248      248           
=======================================
  Hits         1214     1214           
  Misses        678      678           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit dc98e06 into nipreps:master Mar 22, 2024
13 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the repo-review branch March 22, 2024 16:25
@DimitriPapadopoulos DimitriPapadopoulos restored the repo-review branch March 22, 2024 16:25
@DimitriPapadopoulos DimitriPapadopoulos deleted the repo-review branch March 22, 2024 16:26
effigies added a commit that referenced this pull request Mar 23, 2024
0.15.0 (March 22, 2024)

New feature release in the 0.15.x series.

This release adds the workflow configuration option and CLI option
to reuse existing FreeSurfer outputs without attempting to resume.
This should allow for using longitudinal or non-standard pipelines
(for example, FastSurfer) without additional tooling for each variant.

* FIX: Patch version for smriprep-docker (#424)
* FIX: Require recent templateflow, select correct aparc dseg.tsv (#420)
* ENH: Add --fs-no-resume option to reuse existing FreeSurfer outputs without resuming (#393)
* MNT: set copyright owner in LICENSE file (#426)
* MNT: Apply Repo-Review suggestions (#422)
* CI: Small cleanups to GHA (#423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants