Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Better handling consecutive periods and reserved special symbols #78

Merged
merged 4 commits into from
Oct 8, 2020

Conversation

nipunsadvilkar
Copy link
Owner

@nipunsadvilkar nipunsadvilkar commented Sep 11, 2020

  • Better handling Consecutive periods and these symbols - [。..!!??]
  • Update regression tests with respect to it.

🐛 Fix consecutive period bug reference in allenai/scholarphi#114

@nipunsadvilkar nipunsadvilkar changed the title Better handling consecutive periods and reserved special symbols ✨ Better handling consecutive periods and reserved special symbols Sep 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          37       37           
  Lines        1077     1077           
=======================================
  Hits         1060     1060           
  Misses         17       17           
Flag Coverage Δ
#unittests 98.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysbd/lang/common/common.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc61aef...f0e71a5. Read the comment docs.

@nipunsadvilkar nipunsadvilkar self-assigned this Sep 11, 2020
@nipunsadvilkar nipunsadvilkar added bug edge-cases update rules to account for the edge cases enhancement labels Sep 11, 2020
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          37       37           
  Lines        1077     1077           
=======================================
  Hits         1060     1060           
  Misses         17       17           
Flag Coverage Δ
#unittests 98.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysbd/lang/common/common.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc61aef...341434b. Read the comment docs.

@nipunsadvilkar nipunsadvilkar merged commit f953e71 into master Oct 8, 2020
@nipunsadvilkar nipunsadvilkar deleted the npn-consecutive-periods branch October 8, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug edge-cases update rules to account for the edge cases enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants