Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: do not blow hard if prettyfication of json fails - just store as json module stores it #342

Merged
merged 1 commit into from
May 15, 2019
Merged

ENH: do not blow hard if prettyfication of json fails - just store as json module stores it #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion heudiconv/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,17 @@ def treat_infofile(filename):
j = json.load(f)

j_slim = slim_down_info(j)
j_pretty = json_dumps_pretty(j_slim, indent=2, sort_keys=True)
dumps_kw = dict(indent=2, sort_keys=True)
try:
j_pretty = json_dumps_pretty(j_slim, **dumps_kw)
except AssertionError as exc:
lgr.warning(
"Prettyfication of .json failed (%s). "
"Original .json will be kept as is. Please share (if you could) "
"that file (%s) with HeuDiConv developers"
% (str(exc), filename)
)
j_pretty = json.dumps(j_slim, **dumps_kw)

set_readonly(filename, False)
with open(filename, 'wt') as fp:
Expand Down