MNT: Resurrect tox config to cover dev workflows and CI checks #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 99 99
Lines 12457 12458 +1
Branches 2559 2559
=======================================
+ Hits 11485 11486 +1
Misses 648 648
Partials 324 324
☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
mnt/tox
branch
4 times, most recently
from
f9fa917 to
f090354
Compare
effigies
force-pushed
the
mnt/tox
branch
6 times, most recently
from
3ac94be to
8a60853
Compare
|
@matthew-brett @oesteban What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to centralize a lot of details for of our project in a single place:
tox.ini. We've had this file for a while, but it hasn't been updated in ages.This fully replaces our custom
tools/ciscripts with a maintained environment manager that works equally well locally and on CI. It thus also allows us to reduce our CI configuration significantly, as most jobs are now just running a corresponding tox environment.This approach allows us to keep track of our minimum supported dependencies, both optional and required, and track the environments they can be reliably installed on. For example, we can document and test that we support a minimum dependency of scipy 1.6, but this is unavailable for 32-bit builds of Python 3.10+:
# Scipy stopped producing win32 wheels at py310 py3{8,9}-full-x86,x64: scipy >=1.6This PR has gone on long enough. In separate pull requests, it would be good to:
pydicom@masteris failing, so we can restore that in pre-release tests.ruff, a much faster and more fully-featured alternative toflake8.