STY: Apply ruff preview rules #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
preview
branch
from
87ec393 to
c698c5e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
=======================================
Coverage 95.37% 95.37%
=======================================
Files 207 207
Lines 29668 29668
Branches 4991 4990 -1
=======================================
Hits 28296 28296
Misses 932 932
Partials 440 440 ☔ View full report in Codecov by Sentry. |
| @@ -699,7 +699,7 @@ def set_zooms(self, zooms): | |||
| ndim = dims[0] | |||
| zooms = np.asarray(zooms) | |||
| if len(zooms) != ndim: | |||
| raise HeaderDataError('Expecting %d zoom values for ndim %d' % (ndim, ndim)) | |||
There was a problem hiding this comment.
Just wondering, does ndim really must appear twice in the error message?
There was a problem hiding this comment.
I think it's reasonable to say you were expecting N zooms for an N-dim image. I think it would also make sense to rewrite something along the lines of "Zooms must have one value per dimension (ndim={ndim}). Received: {zooms}."
DimitriPapadopoulos
force-pushed
the
preview
branch
from
c698c5e to
53a9ea1
Compare
DimitriPapadopoulos
force-pushed
the
preview
branch
2 times, most recently
from
8164f9d to
aec7b3d
Compare
DimitriPapadopoulos
force-pushed
the
preview
branch
from
aec7b3d to
06736c1
Compare
effigies
reviewed
Oct 1, 2024
effigies
reviewed
Oct 1, 2024
DimitriPapadopoulos
force-pushed
the
preview
branch
2 times, most recently
from
39dec9b to
b75eb13
Compare
UP031 Use format specifiers instead of percent format Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
FURB145 Prefer `copy` method over slicing
FURB148 `enumerate` index is unused, use `for x in y` instead
FURB157 Verbose expression in `Decimal` constructor
FURB192 Prefer `min` over `sorted()` to compute the minimum value in a sequence
C409 Unnecessary list comprehension passed to `tuple()` (rewrite as a generator)
C419 Unnecessary list comprehension
DimitriPapadopoulos
force-pushed
the
preview
branch
from
b75eb13 to
b33bcde
Compare
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.