Skip to content

FIX for [#2557](https://github.com/nipy/nipype/issues/2557#issuecomment-384834681) #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eort
Copy link
Contributor

@eort eort commented Apr 27, 2018

Fixes #2557

Changes proposed in this pull request

  • Don't override empty node config file with the default config information

@eort
Copy link
Contributor Author

eort commented Apr 27, 2018

closed in place of #2559

@eort eort closed this Apr 27, 2018
@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #2558 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
- Coverage   67.12%   66.62%   -0.51%     
==========================================
  Files         333      328       -5     
  Lines       42538    42507      -31     
  Branches     5265     5280      +15     
==========================================
- Hits        28554    28320     -234     
- Misses      13283    13505     +222     
+ Partials      701      682      -19
Flag Coverage Δ
#smoketests 50.73% <ø> (+0.05%) ⬆️
#unittests 63.95% <ø> (-0.5%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/engine/nodes.py 83.55% <ø> (-0.39%) ⬇️
nipype/utils/nipype2boutiques.py 12.03% <0%> (-56.36%) ⬇️
nipype/interfaces/dtitk/utils.py 60.73% <0%> (-31.79%) ⬇️
nipype/scripts/instance.py 37.5% <0%> (-18.75%) ⬇️
nipype/interfaces/ants/base.py 61.7% <0%> (-10.64%) ⬇️
nipype/interfaces/fsl/aroma.py 68.42% <0%> (-7.34%) ⬇️
nipype/algorithms/metrics.py 52.94% <0%> (-5.42%) ⬇️
nipype/pipeline/engine/base.py 83.63% <0%> (-4.83%) ⬇️
nipype/interfaces/dtitk/registration.py 80% <0%> (-4.31%) ⬇️
nipype/interfaces/dcm2nii.py 43.06% <0%> (-4.14%) ⬇️
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9315ca...79d4018. Read the comment docs.

@eort eort deleted the fixWorkflowConfig branch March 22, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants