ENH: replace portalocker with filelock #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting pickled files
oesteban
approved these changes
Sep 10, 2019
satra
commented
Sep 10, 2019
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
|
Perhaps for a future PR it'd great to have an open function that 1) opens a lock and 2) replaces the standard open with gzip's in pickles. |
You can check out |
oesteban
approved these changes
Sep 11, 2019
oesteban
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replacing portalocker with filelock
@oesteban - this may still not resolve a timing issue. for that i don't know of a good solution other than to increase the timeout.
May fix #3024 and others
List of changes proposed in this PR (pull-request)
Acknowledgment