-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Lightweight node cache checking #3026
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3026 +/- ##
==========================================
- Coverage 67.51% 64.18% -3.34%
==========================================
Files 344 342 -2
Lines 44045 43991 -54
Branches 5550 5547 -3
==========================================
- Hits 29739 28237 -1502
- Misses 13567 14628 +1061
- Partials 739 1126 +387
Continue to review full report at Codecov.
|
Generating the hashvalue when outputs are not ready at cache check stage when the node's directory does not exist (or no results file is in there) leads to nipy#3014. This PR preempts those problems by delaying the hashval calculation.
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Travis seems a bit under the weather today. I'll go ahead and merge, making sure master passes all tests. |
Generating the hashvalue when outputs are not ready at cache check stage
when the node's directory does not exist (or no results file is in
there) leads to #3014.
This PR preempts those problems by delaying the hashval calculation.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment