Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Lightweight node cache checking #3026

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Sep 11, 2019

Generating the hashvalue when outputs are not ready at cache check stage
when the node's directory does not exist (or no results file is in
there) leads to #3014.

This PR preempts those problems by delaying the hashval calculation.

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #3026 into master will decrease coverage by 3.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3026      +/-   ##
==========================================
- Coverage   67.51%   64.18%   -3.34%     
==========================================
  Files         344      342       -2     
  Lines       44045    43991      -54     
  Branches     5550     5547       -3     
==========================================
- Hits        29739    28237    -1502     
- Misses      13567    14628    +1061     
- Partials      739     1126     +387
Flag Coverage Δ
#smoketests ?
#unittests 64.18% <100%> (-0.78%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/engine/nodes.py 77.35% <100%> (-6.76%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 50% <0%> (-30.51%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-29.14%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2162c84...ebdada1. Read the comment docs.

Generating the hashvalue when outputs are not ready at cache check stage
when the node's directory does not exist (or no results file is in
there) leads to nipy#3014.

This PR preempts those problems by delaying the hashval calculation.
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
@effigies effigies added this to the 1.2.3 milestone Sep 11, 2019
@oesteban
Copy link
Contributor Author

Travis seems a bit under the weather today. I'll go ahead and merge, making sure master passes all tests.

@oesteban oesteban merged commit c69d4ad into nipy:master Sep 11, 2019
@oesteban oesteban deleted the fix/3014 branch September 11, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants