FIX: Remove asynchronous chdir callback

[stilley2]

Summary

Remove the asynchronous chdir callback in the multiproc plugin

Acknowledgment

• (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

[stilley2]

I know this is being discussed in #3047, but I wanted to get CI running on this change to see if it catches anything (my local tests did not).

[codecov]

Codecov Report

Merging #3060 into master will increase coverage by 3.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3060      +/-   ##
==========================================
+ Coverage   64.07%   67.27%   +3.19%     
==========================================
  Files         342      344       +2     
  Lines       44022    44086      +64     
  Branches     5550     5554       +4     
==========================================
+ Hits        28209    29660    +1451     
+ Misses      14664    13603    -1061     
+ Partials     1149      823     -326

Flag	Coverage Δ
#smoketests	47.86% <ø> (?)
#unittests	65.17% <ø> (+1.1%)	⬆️

Impacted Files	Coverage Δ
nipype/pipeline/plugins/multiproc.py	72.04% <ø> (-0.18%)	⬇️
nipype/interfaces/dynamic_slicer.py	17.47% <0%> (ø)	⬆️
nipype/interfaces/nipy/preprocess.py	45.79% <0%> (ø)	⬆️
nipype/__init__.py	68.08% <0%> (ø)
nipype/testing/__init__.py	88.88% <0%> (ø)
nipype/algorithms/misc.py	45.68% <0%> (+0.11%)	⬆️
nipype/interfaces/afni/preprocess.py	81.97% <0%> (+0.22%)	⬆️
nipype/interfaces/dipy/reconstruction.py	33% <0%> (+0.97%)	⬆️
nipype/interfaces/dipy/tracks.py	31.66% <0%> (+1.11%)	⬆️
nipype/interfaces/dipy/preprocess.py	27.37% <0%> (+1.11%)	⬆️
... and 51 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa28d5...47dc288. Read the comment docs.

[oesteban]

Thanks for this.

[effigies]

The problem that led to this, though, was something calling getcwd() from a deleted directory. Has that root cause gone away?

[oesteban]

It should be. Virtually any getcwd() call from a worker that was initiated in a nonexistent folder would crash. But that problem is addressed by the init hook included in that old PR. The chdir being removed is the result of my desperation at that moment.

[effigies]

Okay. I'll defer to your memory on that one.

[effigies]

@oesteban I was assuming you were going to merge this. Is there a hold-up, or were you waiting for a second approval?

[oesteban]

Sorry for the delay