Skip to content

STY: Remove duplicated trait in EddyOutputSpec #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023

Conversation

yibeichan
Copy link
Contributor

out_shell_pe_translation_parameters in fsl.epi.eddy appeared twice, removed the second one to avoid redundancy

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (450be34) 63.34% compared to head (fc8cae7) 63.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   63.34%   63.34%   -0.01%     
==========================================
  Files         309      309              
  Lines       40904    40903       -1     
  Branches     5381     5381              
==========================================
- Hits        25911    25910       -1     
  Misses      13985    13985              
  Partials     1008     1008              
Impacted Files Coverage Δ
nipype/interfaces/fsl/epi.py 61.88% <ø> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member

Surprised this isn't something flake8 catches.

@effigies effigies changed the title remove redundant out_shell_pe_translation_parameters STY: Remove duplicated trait in EddyOutputSpec May 10, 2023
@effigies effigies merged commit 56c8817 into nipy:master May 10, 2023
@yibeichan yibeichan deleted the yibeichan-patch-1 branch May 10, 2023 15:04
@effigies effigies mentioned this pull request Mar 20, 2024
6 tasks
@effigies effigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants