[FIX] Set length to 1 when np.squeeze returns a 0D array #3713
Conversation
|
@man-shu I'm not sure if this code actually gets tested by our tests. If you're testing on your end, please make sure that it works in cases where it was previously failing. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
===========================================
- Coverage 73.07% 50.84% -22.23%
===========================================
Files 1278 1278
Lines 59406 59367 -39
===========================================
- Hits 43411 30187 -13224
- Misses 15995 29180 +13185 ☔ View full report in Codecov by Sentry. |
Ok will update you on that. |
|
@man-shu Have you had a chance to test this? |
|
Sorry not yet! Our HPC has been down since the day I opened this PR. Our IT dept is telling us that it should be ok by next week, so I hope to get back to you then. (I tried copying the original nipype cache locally and then run it, but then it just started a fresh run because the checksum didn't match.) |
|
Hello @effigies ! I finally ran the full pipeline with and without this fix and both of them worked. I do not have access to the cache for the failing run either. Do you have any suggestions on how to proceed from here? |
|
Just need to eyeball it, then. It still looks right to me after a few weeks, so let's merge. |
1.10.0 (March 19, 2025) New feature release in the 1.10.x series. This release adds GPUs to multiprocess resource management. In general, no changes to existing code should be required if the GPU-enabled interface has a ``use_gpu`` input. The ``n_gpu_procs`` can be used to set the number of GPU processes that may be run in parallel, which will override the default of GPUs identified by ``nvidia-smi``, or 1 if no GPUs are detected. * FIX: Reimplement ``gpu_count()`` (#3718) * FIX: Avoid 0D array in ``algorithms.misc.merge_rois`` (#3713) * FIX: Allow nipype.sphinx.ext.apidoc Config to work with Sphinx 8.2.1+ (#3716) * FIX: Resolve crashes when running workflows with updatehash=True (#3709) * ENH: Support for gpu queue (#3642) * ENH: Update to .wci.yml (#3708) * ENH: Add Workflow Community Initiative (WCI) descriptor (#3608)
2 participants
Summary
Fixes #3712 .
List of changes proposed in this PR (pull-request)
idxsidxsis a 0D array)nelsto 1