Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Load ITK fields from H5 correctly #211

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

effigies
Copy link
Member

Ports nipreps/fmriprep#3300 to nitransforms.

I've gotten ANTs to generate a warp field with a non-cardinal rotation matrix and anistropic spacing:

image

Need to verify that we're raveling the fixed parameters in the correct order. Numpy defaults to C.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (d6170fb) to head (1c74669).
Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          14       14           
  Lines        1307     1307           
  Branches      259      259           
=======================================
  Hits         1252     1252           
  Misses         52       52           
  Partials        3        3           
Flag Coverage Δ
unittests 95.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

Oh no.

image

@effigies
Copy link
Member Author

In [37]: np.allclose(np.diag([-1, -1, 1, 1]) @ targetrot, nb.affines.from_matvec(np.reshape(params, (3, 3))))
Out[37]: True

nitransforms/io/itk.py Outdated Show resolved Hide resolved
@effigies effigies merged commit 2ccc490 into nipy:master Jul 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant