Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use standard library pathlib #222

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Sep 7, 2024

With

python_requires = >= 3.8
and pathlib incorporated into the standard Python library in v3.4, we should rely on the pathlib in the standard Python library, not the unmaintained pathlib on PyPI intended for Python < 3.4.

Related: #203 (comment), #203 (comment)

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (cd10b71) to head (b2a404f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          15       15           
  Lines        1756     1756           
  Branches      328      328           
=======================================
  Hits         1664     1664           
  Misses         76       76           
  Partials       16       16           
Flag Coverage Δ
unittests 94.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 5aa2473 into nipy:master Sep 8, 2024
10 checks passed
@shnizzedy shnizzedy deleted the fix/pathlib branch September 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants