Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list as a single element of an input #160

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Jan 3, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

addressing issue with tasks that requires list as a single input: had examples for the task only without state. For tasks with a state decided to use a tuple (not a list) to distinguish between a "single element" and multiple elements that should be split.

For shell task, command_args had to be modified so it passes multiple elements, not a tuple.

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

… assuming that tuple has to be used to be recognized as a sigle element that goes to a task); fixing command_args, so it converts a tuple to a list
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #160 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   86.74%   86.63%   -0.11%     
==========================================
  Files          17       17              
  Lines        2655     2657       +2     
  Branches      679      680       +1     
==========================================
- Hits         2303     2302       -1     
- Misses        230      231       +1     
- Partials      122      124       +2
Flag Coverage Δ
#unittests 86.63% <50%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pydra/engine/task.py 86.84% <100%> (ø) ⬆️
pydra/engine/helpers.py 84.9% <33.33%> (-1.09%) ⬇️
pydra/__init__.py 68.75% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e72bf...a872608. Read the comment docs.

@djarecka djarecka merged commit 3f3f59e into nipype:master Jan 3, 2020
@djarecka djarecka deleted the list_inp branch December 30, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant