-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes SerialWorker Implementation #507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 78.42% 78.60% +0.18%
==========================================
Files 20 20
Lines 4305 4301 -4
Branches 1218 1217 -1
==========================================
+ Hits 3376 3381 +5
+ Misses 733 725 -8
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The only test that is failing is a SLURM one that appears to be unrelated to my changes. I’m assuming it was introduced when I last merged the master. @djarecka if you have a moment to look at the PR it would be great to have it merged in for the next micro release if possible (so I can release another version of arcana that depends on them) |
@tclose - i thought that reruning the test will help, but it didn't. I will run/debug the test on our local slurm and see. |
@djarecka seems like rerunning the tests did the trick on the second attempt. Is it okay to merge now? |
that's great! Thank you! |
Acknowledgment
Types of changes
Summary
Updates the implementation of serial worker so that it works with latest version of Pydra
Checklist
(we are using
black
: you canpip install pre-commit
,run
pre-commit install
in thepydra
directoryand
black
will be run automatically with each commit)