Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more output types to use callables #557

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Conversation

yibeichan
Copy link
Collaborator

@yibeichan yibeichan commented Jul 21, 2022

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

  • allow File, MultiOutputFile, and Directory in outputs to use callables

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #557 (2aecd6f) into master (eb48e0a) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   77.06%   77.06%           
=======================================
  Files          20       20           
  Lines        4316     4316           
  Branches     1212     1212           
=======================================
  Hits         3326     3326           
  Misses        802      802           
  Partials      188      188           
Flag Coverage Δ
unittests 76.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/specs.py 88.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb48e0a...2aecd6f. Read the comment docs.

@yibeichan
Copy link
Collaborator Author

hello @djarecka , I've added tests for MultiOutputFile and Directory respectively.

@djarecka
Copy link
Collaborator

@yibeichan - not sure why codecov/path complains, but sometimes it happens, especially with a very short PR. Will merge it

@djarecka djarecka merged commit ac06f8c into nipype:master Jul 22, 2022
@yibeichan yibeichan deleted the fix-specs branch July 25, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants