Make Makefile compatible with macOS #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like macOS distribution of `rm` does not understand long versions of flag names, such as --force or --recursive. This PR switches to their respective short versions (-f and -r) to increase compatibility.
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 77.13% 77.06% -0.07%
==========================================
Files 20 20
Lines 4316 4316
Branches 1212 1212
==========================================
- Hits 3329 3326 -3
- Misses 799 802 +3
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like macOS distribution of
rmdoes not understand long versions offlag names, such as --force or --recursive. This PR switches to their
respective short versions (-f and -r) to increase compatibility.