Implementation of proposed syntax changes #768
Conversation
pydra/design/base.py
Outdated
| List of allowed values for the field. | ||
| xor: Sequence[str | None], optional | ||
| Names of args that are exclusive mutually exclusive, which must include | ||
| the name of the current field. If this list includes None, then none of the |
There was a problem hiding this comment.
including the current field was not the case in nipype or the previous version of pydra i believe. reducing this kind of boilerplate would be helpful, and also if xor is commutative without specification (a xor b implies b xor a and should not have to be specified in both places - just one should do the other should be computed). also any checks to make sure xor combinations are valid or invalid (e.g. a xor b, b xor c, c xor a)
There was a problem hiding this comment.
I was thinking it would be better as an argument to the shell.define decorator/function, so it would only need to be defined once, and it is really a "task-level" attribute
There was a problem hiding this comment.
so a list of lists? i.e. there could be multiple different xors in a task.
There was a problem hiding this comment.
Yes, maybe list[str] | list[list[str]] could be acceptable inputs
…xture (from "debug")
…dules starting with "_"
…ching to state indices
Types of changes
Summary
Implements proposed syntax changes in #692
Test modules (to fix)
Checklist