Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release task #113

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Release task #113

merged 2 commits into from
Mar 29, 2021

Conversation

hannesa2
Copy link
Contributor

No description provided.

@hannesa2
Copy link
Contributor Author

Now it works....

niqdev
niqdev reviewed Mar 28, 2021
View reviewed changes
.github/workflows/Android-CI-release.yml
VERSION: ${{ github.ref }}
- run: |
assetsAAR=$(find . -name *release.aar | while read -r asset ; do echo "-a $asset" ; done)
hub release create ${assetsAAR} -m ${{steps.tagger.outputs.tag}} ${{steps.tagger.outputs.tag}}
Copy link
Owner

@niqdev niqdev Mar 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this that will attach the artifact to the release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

niqdev
niqdev reviewed Mar 28, 2021
View reviewed changes
README.md
@@ -1,7 +1,6 @@
# ipcam-view ![ipcam-view](images/logo.png)

[![Android Arsenal](https://img.shields.io/badge/Android%20Arsenal-ipcam--view-brightgreen.svg?style=flat)](http://android-arsenal.com/details/1/3358)
[![Download](https://api.bintray.com/packages/niqdev/maven/mjpeg-view/images/download.svg)](https://bintray.com/niqdev/maven/mjpeg-view/_latestVersion)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to add JitPack in a different PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's less work, when you do it. You have the power to edit README.md directly

Please add this info https://jitpack.io/#niqdev/ipcam-view/v1.6.0

image

This is the batch
[![](https://jitpack.io/v/niqdev/ipcam-view.svg)](https://jitpack.io/#niqdev/ipcam-view)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I'll take care of that

@niqdev niqdev merged commit abf09d5 into niqdev:master Mar 29, 2021
@niqdev
Copy link
Owner

niqdev commented Mar 29, 2021

Adding just a note in case I'll come back to this. It works only by pushing tags, if you create a release from the ui it will fail with

Error creating release: Unprocessable Entity (HTTP 422)
Duplicate value for "tag_name"
Error: Process completed with exit code 1.

See https://github.com/niqdev/ipcam-view/actions/runs/697292886

@hannesa2 hannesa2 deleted the ReleaseTask branch March 29, 2021 10:29
@hannesa2
Copy link
Contributor Author

Adding just a note in case I'll come back to this. It works only by pushing tags, if you create a release from the ui it will

Of course it wlll fail !
A new tag will create a release, but when you do it vice versa (first a release, then a (automatic) tag) it's already there !

@hannesa2
Copy link
Contributor Author

hannesa2 commented Mar 29, 2021 •
edited
Loading

I see you did it (finally ?) the right way 👍 Triggered by github action with artifact

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niqdev niqdev niqdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesa2 @niqdev