increase maximum frame size to support newer cameras #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase maximum frame size from 40,000 bytes to 200,000 bytes to support newer high resolution cameras which can produce larger frames. Without this change in place the parser fails to detect the start and end frame markers if the frame size happens to be larger than 40,000 bytes. Surely there is a better way of doing this, but this was the easiest way to get around the problem.
|
Nothing against this magic number. 👍 Just if someone comes with too much time, he could put right value under |
|
It would be easy enough to move it into res if that is desired. |
|
Thanks for the feedback! |
niqdev
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase maximum frame size from 40,000 bytes to 200,000 bytes to support newer high resolution cameras which can produce larger frames.
Without this change in place the parser fails to detect the start and end frame markers if the frame size happens to be larger than 40,000 bytes.
Surely there is a better way of doing this, but this was the easiest way to get around the problem.